Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Add warning and hint for legacy metrics #867

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Aug 30, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

bugfix

What this PR does / why we need it:

After dbt 1.6 the legacy metrics are no longer supported, users should migrate to the MetricFlow

Which issue(s) this PR fixes:

sc-32180


image

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #867 (3833414) into main (9ae345d) will increase coverage by 0.05%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   47.82%   47.88%   +0.05%     
==========================================
  Files          71       71              
  Lines        9994    10003       +9     
==========================================
+ Hits         4780     4790      +10     
+ Misses       5214     5213       -1     
Files Changed Coverage Δ
piperider_cli/compare_report.py 31.52% <88.88%> (+1.43%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ching Yi, Chan <[email protected]>
@qrtt1 qrtt1 requested a review from ctiml August 30, 2023 07:36
@qrtt1 qrtt1 merged commit f128375 into main Aug 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants