Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] performance tuning #865

Closed
wants to merge 4 commits into from
Closed

[Chore] performance tuning #865

wants to merge 4 commits into from

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Aug 29, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

enhancement

What this PR does / why we need it:

Make CLI respond quickly

Which issue(s) this PR fixes:

none


Tools

pyinstrument $(command -v piperider)

re-arrange imports

  • to import the list_task package cost lot of time
    image

  • cloud connector
    image

  • compare_wit_recipe
    image

Signed-off-by: Ching Yi, Chan <[email protected]>
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #865 (0a0b7d2) into main (9ae345d) will decrease coverage by 1.69%.
The diff coverage is 29.91%.

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
- Coverage   47.82%   46.13%   -1.69%     
==========================================
  Files          71       73       +2     
  Lines        9994    10050      +56     
==========================================
- Hits         4780     4637     -143     
- Misses       5214     5413     +199     
Files Changed Coverage Δ
piperider_cli/cli_utils/compare_with_recipe.py 0.00% <0.00%> (ø)
piperider_cli/cli.py 67.10% <31.81%> (+5.38%) ⬆️
piperider_cli/cli_utils/cloud_state.py 60.00% <60.00%> (ø)
piperider_cli/dbtutil.py 75.14% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qrtt1 qrtt1 marked this pull request as draft August 29, 2023 05:34
@qrtt1 qrtt1 closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant