Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update bigquery denpendencies #864

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Aug 28, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

chore

What this PR does / why we need it:

make sure the user installing new enough library

Which issue(s) this PR fixes:

sc-32092

Special notes for your reviewer:

python-bigquery-sqlalchemy has not supported sqlalchemy 2 yet.

googleapis/python-bigquery-sqlalchemy#510 (comment)

Signed-off-by: Ching Yi, Chan <[email protected]>
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #864 (109851b) into main (6e5e4bf) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #864   +/-   ##
=======================================
  Coverage   47.82%   47.82%           
=======================================
  Files          71       71           
  Lines        9994     9994           
=======================================
  Hits         4780     4780           
  Misses       5214     5214           
Files Changed Coverage Δ
piperider_cli/datasource/bigquery.py 20.57% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qrtt1 qrtt1 merged commit 9ae345d into main Aug 28, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant