Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fix compatible problem for dbt-1.3 and dbt-1.6.1 #859

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

qrtt1
Copy link
Contributor

@qrtt1 qrtt1 commented Aug 24, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?

Bug

What this PR does / why we need it:

  • fix dbt-1.3 broken by flags function
  • add the new flag introduced from dbt-1.6.1
image

image

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #859 (d796ed1) into main (c6da5d0) will increase coverage by 0.02%.
The diff coverage is 77.77%.

❗ Current head d796ed1 differs from pull request most recent head 32a278c. Consider uploading reports for the commit 32a278c to get more accurate results

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
+ Coverage   47.87%   47.90%   +0.02%     
==========================================
  Files          71       71              
  Lines        9948     9955       +7     
==========================================
+ Hits         4763     4769       +6     
- Misses       5185     5186       +1     
Files Changed Coverage Δ
piperider_cli/dbt/list_task.py 64.92% <77.77%> (+0.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ching Yi, Chan <[email protected]>
@qrtt1 qrtt1 force-pushed the bug/dbt-1.3-broken-with-flags branch from d796ed1 to 32a278c Compare August 24, 2023 03:02
@qrtt1 qrtt1 changed the title [Bug] Fix flag creation (dbt-1.3 compatible) [Bug] fix compatible problem for dbt-1.3 and dbt-1.6.1 Aug 24, 2023
@qrtt1 qrtt1 merged commit 93e5a11 into main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant