Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SGLang & modify model source API #68

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Support SGLang & modify model source API #68

merged 1 commit into from
Aug 6, 2024

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Aug 6, 2024

What this PR does / why we need it

  1. Support SGLang
  2. Support loading models from ModelScope
  3. Change model dataSource to Source
  4. Support model revision when loading from modelHub
  5. Update the examples
  6. Update README.md

Which issue(s) this PR fixes

Fixes #39
Fixes #19

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 6, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Aug 6, 2024

/lgtm
/approve

@kerthcet
Copy link
Member Author

kerthcet commented Aug 6, 2024

/kind feature
/api-change

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 6, 2024
@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 6, 2024
@InftyAI-Agent InftyAI-Agent removed the lgtm Looks good to me, indicates that a PR is ready to be merged. label Aug 6, 2024
@kerthcet
Copy link
Member Author

kerthcet commented Aug 6, 2024

/lgtm

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Aug 6, 2024
@InftyAI-Agent InftyAI-Agent merged commit b43c7c6 into InftyAI:main Aug 6, 2024
19 checks passed
@kerthcet kerthcet deleted the refactor/readme branch August 6, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SGLang as another backend Support DataSource of ModelScope
2 participants
@kerthcet @InftyAI-Agent