Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/N] Add support for per model deployment #25

Merged
merged 1 commit into from
Jul 17, 2024
Merged

[1/N] Add support for per model deployment #25

merged 1 commit into from
Jul 17, 2024

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Jul 17, 2024 •
edited
Loading

What we do in this PR:

  • Add e2e test framework: fix Add E2E test framework #12
  • Add client-go codes
  • Add support for per model deployment, most of the part is implemented
  • Rename api/v1alpha1 to api/core/v1alpha1 to avoid code-generator bug, will revisit this part later

Already big enough, merge as the first step.

@kerthcet
Copy link
Member Author

/kind feature

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jul 17, 2024
kerthcet
kerthcet commented Jul 17, 2024
View reviewed changes
api/core/v1alpha1/types.go
This file is needed for kubernetes/code-generator/kube_codegen.sh script used in hack/update-codegen.sh.
*/

package v1alpha1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary to trigger code generator.

@kerthcet
Copy link
Member Author

/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 17, 2024
@InftyAI-Agent InftyAI-Agent merged commit 435234d into InftyAI:main Jul 17, 2024
14 of 15 checks passed
@kerthcet kerthcet deleted the feat/api-defination branch July 17, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kerthcet kerthcet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add E2E test framework
2 participants
@kerthcet @InftyAI-Agent