Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sharing model weights across Pods in the same node #102

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

kerthcet
Copy link
Member

What this PR does / why we need it

Stop sharing models in the same node because right now, we have no model weights lifecycle management policies, which may lead to the model size growing all the time.

This can be handled by fluid somehow.

Which issue(s) this PR fixes

Fixes #88

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 21, 2024
@kerthcet kerthcet changed the title Stop sharing across Pods in the same node Stop sharing model weights across Pods in the same node Aug 21, 2024
@kerthcet
Copy link
Member Author

/kind bug
/lgtm
/approve

@InftyAI-Agent InftyAI-Agent added bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Aug 21, 2024
@InftyAI-Agent InftyAI-Agent merged commit 364f645 into InftyAI:main Aug 21, 2024
44 checks passed
@kerthcet kerthcet deleted the feat/add-scheduler branch August 21, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bug Categorizes issue or PR as related to a bug. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always download the model weights when pod starts
2 participants