fix: 'changeToolbarColorOnScroll' crash #2089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasBourdin88
added
bug
|
LunarX
requested changes
Nov 5, 2024
Comment on lines
+495
to
+497
| if (shouldUpdateStatusBar()) { | ||
| viewLifecycleOwner.lifecycleScope.launch(Dispatchers.Main) { requireActivity().window.statusBarColor = color } | ||
| } |
There was a problem hiding this comment.
But, this should have already been fixed, I don't understand.
There's a already a Dispatchers.Main inside animateColorChange(), there should be no point in adding a second one here, why is it not enough?
Also, there should be other lines of code that will crash if not on the main Thread such as toolbar.setBackgroundColor(color) and otherUpdates?.invoke(color). Do they not crash?
|
Already fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.