Apply suggestions from code review

Infomaniak · Nov 24, 2023 · 5ee9c05 · 5ee9c05
1 parent 4718601
commit 5ee9c05
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/Stores/src/fdroid/java/com.infomaniak.lib.stores/StoreUtils.kt b/Stores/src/fdroid/java/com.infomaniak.lib.stores/StoreUtils.kt
@@ -30,14 +30,13 @@ import kotlinx.coroutines.withContext
 object StoreUtils {
 
     //region In-App Update
-
     fun initAppUpdateManager(context: Context, onInstall: () -> Unit) = Unit
 
     fun FragmentActivity.checkUpdateIsAvailable(
         appId: String,
         versionCode: Int,
-        resultLauncher: ActivityResultLauncher<IntentSenderRequest>,
-        onResult: (updateIsAvailable: Boolean) -> Unit,
+        inAppResultLauncher: ActivityResultLauncher<IntentSenderRequest>,
+        onFDroidResult: (updateIsAvailable: Boolean) -> Unit,
     ) {
         lifecycleScope.launch {
             val lastVersionCode = FdroidApiTools().getLastRelease(appId)
@@ -56,7 +55,6 @@ object StoreUtils {
     //endregion
 
     //region In-App Review
-
     fun FragmentActivity.launchInAppReview() = Unit
     //endRegion
 }
diff --git a/Stores/src/standard/java/com.infomaniak.lib.stores/StoreUtils.kt b/Stores/src/standard/java/com.infomaniak.lib.stores/StoreUtils.kt
@@ -50,7 +50,6 @@ object StoreUtils {
     }
 
     //region In-App Update
-
     fun initAppUpdateManager(context: Context, onInstall: () -> Unit) {
         appUpdateManager = AppUpdateManagerFactory.create(context)
         onInstallDownloaded = onInstall
@@ -59,14 +58,14 @@ object StoreUtils {
     fun checkUpdateIsAvailable(
         appId: String,
         versionCode: Int,
-        resultLauncher: ActivityResultLauncher<IntentSenderRequest>,
-        onResult: (updateIsAvailable: Boolean) -> Unit,
+        inAppResultLauncher: ActivityResultLauncher<IntentSenderRequest>,
+        onFdroidResult: (updateIsAvailable: Boolean) -> Unit,
     ) {
         appUpdateManager.appUpdateInfo.addOnSuccessListener { appUpdateInfo ->
             if (appUpdateInfo.updateAvailability() == UpdateAvailability.UPDATE_AVAILABLE
                 && appUpdateInfo.isUpdateTypeAllowed(UPDATE_TYPE)
             ) {
-                startUpdateFlow(appUpdateInfo, resultLauncher)
+                startUpdateFlow(appUpdateInfo, inAppResultLauncher)
             }
         }
     }
@@ -103,7 +102,6 @@ object StoreUtils {
     //endregion
 
     //region In-App Review
-
     fun FragmentActivity.launchInAppReview() {
         ReviewManagerFactory.create(this).apply {
             val requestReviewFlow = requestReviewFlow()