Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Matomo & Sentry opt-out related screens #90

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Add Matomo & Sentry opt-out related screens #90

merged 9 commits into from
Nov 4, 2024
+362 −4

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Oct 15, 2024 •
edited
Loading

Depends on #137

@KevinBoulongne KevinBoulongne requested a review from a team October 15, 2024 09:07
@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 2 times, most recently from cdc4e0b to d3ef937 Compare October 15, 2024 09:18
@KevinBoulongne KevinBoulongne changed the base branch from clean-xml to settings-data-strings October 15, 2024 09:19
@KevinBoulongne KevinBoulongne changed the base branch from settings-data-strings to settings-data-images October 15, 2024 09:24
@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 2 times, most recently from ca6bac4 to c208a3c Compare October 15, 2024 09:25
LunarX
LunarX previously requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose that the whole feature be in its own Android module so it can be reused in all future apps easily

@KevinBoulongne KevinBoulongne requested review from LunarX and a team October 15, 2024 10:07
@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 2 times, most recently from 77a505a to f72d27b Compare October 17, 2024 07:49
Base automatically changed from settings-data-images to main October 17, 2024 08:06
@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 3 times, most recently from 711e67f to 1341ab5 Compare October 17, 2024 09:48
@KevinBoulongne KevinBoulongne changed the base branch from replace-file-ui-class to bump-ST-kmp October 31, 2024 05:44
@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 2 times, most recently from 4ff232c to 925a792 Compare October 31, 2024 08:07
Base automatically changed from bump-ST-kmp to main October 31, 2024 08:59
@github-actions GitHub Actions
Copy link

This PR/issue depends on:

@KevinBoulongne KevinBoulongne force-pushed the settings-data branch 3 times, most recently from 3bad309 to 55c0428 Compare November 1, 2024 10:22
tevincent
tevincent requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@tevincent tevincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove DATA_SOURCE_CODE ?

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 25ae965 into main Nov 4, 2024
4 checks passed
@KevinBoulongne KevinBoulongne deleted the settings-data branch November 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tevincent tevincent tevincent approved these changes

@LunarX LunarX Awaiting requested review from LunarX

Assignees

@KevinBoulongne KevinBoulongne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBoulongne @LunarX @tevincent