Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify contentPadding usage #79

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Sep 25, 2024

Avoid passing the content padding through too many files when we don't need to. The freedom to handle the contentPaddings manually everywhere down the line is not needed.

Depends on #78

@LunarX LunarX added enhancement New feature or request quick A pull request consisting of a few lines labels Sep 25, 2024
@LunarX LunarX requested a review from sirambd September 25, 2024 13:15
@LunarX LunarX self-assigned this Sep 25, 2024
Base automatically changed from top-app-bar to main September 25, 2024 13:18
@LunarX LunarX force-pushed the top-app-bar-padding-simplification branch from 30cace9 to bead296 Compare September 25, 2024 13:46
Copy link

This PR/issue depends on:

@LunarX LunarX force-pushed the top-app-bar-padding-simplification branch from bead296 to fcf44c0 Compare September 25, 2024 14:15
Avoid passing the content padding through too many files when we don't need to. The freedom to handle the contentPaddings manually everywhere down the line is not needed.
@LunarX LunarX force-pushed the top-app-bar-padding-simplification branch from fcf44c0 to df80f14 Compare September 25, 2024 14:26
@KevinBoulongne KevinBoulongne changed the title Simplify contentPadidng usage Simplify contentPadding usage Sep 25, 2024
Copy link

@LunarX LunarX merged commit f6eeb36 into main Sep 25, 2024
6 checks passed
@LunarX LunarX deleted the top-app-bar-padding-simplification branch September 25, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quick A pull request consisting of a few lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants