Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings option style #66

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Fix settings option style #66

merged 5 commits into from
Sep 20, 2024

Conversation

LunarX
Copy link
Contributor

@LunarX LunarX commented Sep 19, 2024

This PR does the following:

  • updates the font style of options to match the spec
  • update the padding of option screen's gray subtitles
  • simplify option screen definition by introducing a scaffold
  • fix option's height when they have an icon or when they don't

@LunarX LunarX added the enhancement New feature or request label Sep 19, 2024
@LunarX LunarX requested a review from a team September 19, 2024 07:00
@LunarX LunarX self-assigned this Sep 19, 2024
@LunarX LunarX mentioned this pull request Sep 19, 2024
Merged
@KevinBoulongne KevinBoulongne mentioned this pull request Sep 19, 2024
Merged
sirambd
sirambd requested changes Sep 20, 2024
View reviewed changes
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt Outdated Show resolved Hide resolved
...ain/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsEmailLanguageScreen.kt Show resolved Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsDownloadsLimitScreen.kt Show resolved Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsValidityPeriodScreen.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/components/Titles.kt Show resolved Hide resolved
@LunarX LunarX force-pushed the fix-settings-option-style branch from e706055 to 98fc272 Compare September 20, 2024 07:16
@LunarX LunarX requested a review from sirambd September 20, 2024 07:16
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sirambd sirambd merged commit 79962b4 into main Sep 20, 2024
4 checks passed
@sirambd sirambd deleted the fix-settings-option-style branch September 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

@tevincent tevincent tevincent approved these changes

@sirambd sirambd sirambd approved these changes

Assignees

@LunarX LunarX

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LunarX @KevinBoulongne @sirambd @tevincent