-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting option composable method to easily create a group of mutually exclusive options #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
settings-selector
branch
from
August 20, 2024 09:19
198fccf
to
f4844e1
Compare
LunarX
force-pushed
the
settings-selector
branch
4 times, most recently
from
August 20, 2024 13:44
177a255
to
314ce99
Compare
LunarX
force-pushed
the
settings-selector
branch
from
August 20, 2024 14:25
314ce99
to
603ad5d
Compare
This PR/issue depends on:
|
LunarX
force-pushed
the
settings-selector
branch
from
August 21, 2024 06:59
603ad5d
to
8e183dd
Compare
sirambd
requested changes
Aug 21, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
.../com/infomaniak/swisstransfer/ui/screen/main/settings/components/MutuallyExclusiveOptions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsThemeScreen.kt
Outdated
Show resolved
Hide resolved
Here it's fine but as a good practice, so people don't take inspiration from the wrong way of writing things
LunarX
force-pushed
the
settings-selector
branch
from
August 21, 2024 12:45
9a0c336
to
e5d87f6
Compare
sirambd
approved these changes
Aug 21, 2024
sirambd
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual values will come later
Depends on #28