-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add EmailAddressTextField #258
Open
FabianDevel
wants to merge
17
commits into
main
Choose a base branch
from
add-mail-for-transfer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianDevel
force-pushed
the
add-mail-for-transfer
branch
from
December 17, 2024 15:02
fd276d3
to
ae7a37a
Compare
FabianDevel
changed the title
feat: Add mail for transfer
feat: Add EmailAddressTextField
Dec 17, 2024
…r moving to it with directional arrows
FabianDevel
force-pushed
the
add-mail-for-transfer
branch
from
December 17, 2024 15:20
944c004
to
48a6b99
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still isn't perfect but I couldn't figure out how to fix the problems before the Beta, and with the current state of Material's component
For now : the keyboard is hidden when selecting the chips (so you can only remove them with a physical keyboard or click on the trailing icon)
The textField lose focus when the chips are selected, I found a way to fix this but it created a bug when navigating and removing the chips with the physical keyboard.
Also the chip "shrink / expand" logic is not implemented yet