feat: Add confirmation when trying to leave the new transfer flow #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunarX
force-pushed
the
mail-validation-ui
branch
from
4fe805d to
2f92daf
Compare
LunarX
force-pushed
the
ask-user-before-leaving-new-transfer
branch
2 times, most recently
from
f8b8d2c to
87feb4a
Compare
LunarX
force-pushed
the
mail-validation-ui
branch
from
2f92daf to
b9cff14
Compare
tevincent
requested changes
Dec 16, 2024
|
This PR/issue depends on:
|
LunarX
force-pushed
the
ask-user-before-leaving-new-transfer
branch
4 times, most recently
from
becbb9b to
f914928
Compare
tevincent
requested changes
Dec 17, 2024
LunarX
force-pushed
the
ask-user-before-leaving-new-transfer
branch
4 times, most recently
from
4fb2cf2 to
a2fd0bf
Compare
Don't let them escape!
When canceling an upload in progress, you'll be asked to confirm a first time and then when you're back on ImportFilesScreen, you'll need to confirm again to leave. This takes way too many clicks, the confirmation on ImportFilesScreen is not needed
LunarX
force-pushed
the
ask-user-before-leaving-new-transfer
branch
from
a2fd0bf to
d270eac
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't let them escape!
This required me to refactor the dialog composable we already have to have greater control over the buttons. I opted for a more standard interfacing logic instead of adding a lot of parameters. We can now compose the dialog with buttons. There's still two constant buttons already defined for the standard cases.
This PR also required to add stacking buttons in dialogs when the buttons are too wide which required to change the design of the buttons for plain text buttons like the native material theme so they are not misaligned when stacked.
Depends on #254