Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch openInputStream crash and count it as a "failed file" #224

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: Catch openInputStream crash and count it as a "failed file" #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8839b62
fix: Catch openInputStream crash and count it as a "failed file"
LunarX Dec 2, 2024
beef9af
refactor: Fix sentry log to only log it when the openInputStream will…
LunarX Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...c/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/ImportationFilesManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ class ImportationFilesManager @Inject constructor(
}

private fun openInputStream(uri: Uri): InputStream? {
return appContext.contentResolver.openInputStream(uri) ?: run {
SentryLog.w(ImportLocalStorage.TAG, "During local copy of the file openInputStream returned null")
null
}
return runCatching { appContext.contentResolver.openInputStream(uri) }
.onSuccess {
if (it == null) SentryLog.w(ImportLocalStorage.TAG, "During local copy of the file openInputStream returned null")
}
.getOrNull()
}

private fun getRestoredFileUi(localFiles: Array<File>): List<FileUi> {
Expand Down