feat: Onboarding #222
Merged
feat: Onboarding #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
KevinBoulongne
requested changes
Dec 3, 2024
FabianDevel
requested changes
Dec 3, 2024
Core2/Onboarding/src/main/java/com/infomaniak/library/onboarding/OnboardingScaffold.kt
Outdated
Show resolved
Hide resolved
Core2/Onboarding/src/main/java/com/infomaniak/library/onboarding/OnboardingScaffold.kt
Outdated
Show resolved
Hide resolved
Core2/Onboarding/src/main/java/com/infomaniak/library/onboarding/OnboardingScaffold.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/OnboardingScreen.kt
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/onboarding/OnboardingScreen.kt
Outdated
Show resolved
Hide resolved
...ava/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
Outdated
Show resolved
Hide resolved
...ava/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
Show resolved
Hide resolved
...ava/com/infomaniak/swisstransfer/ui/screen/onboarding/components/AnimatedOnboardingButton.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Dec 3, 2024
Core2/Onboarding/src/main/java/com/infomaniak/library/onboarding/OnboardingScaffold.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Dec 3, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/components/HighlightedText.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/HighlightedText.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/HighlightedText.kt
Outdated
Show resolved
Hide resolved
KevinBoulongne
requested changes
Dec 3, 2024
app/src/main/java/com/infomaniak/swisstransfer/ui/images/illus/onboarding/StorageBoxPileDark.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/images/illus/onboarding/StorageBoxPileDark.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/images/illus/onboarding/StorageBoxPileDark.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/infomaniak/swisstransfer/ui/images/illus/onboarding/StorageBoxPileLight.kt
Outdated
Show resolved
Hide resolved
...src/main/java/com/infomaniak/swisstransfer/ui/images/illus/onboarding/StorageBoxPileLight.kt
Outdated
Show resolved
Hide resolved
LunarX
force-pushed
the
onboarding
branch
9 times, most recently
from
995d027 to
03aada6
Compare
The page's content didn't scroll vertically up to the top edge of the screen correctly and was missing some horizontal padding if the width of the illustration is too large
Copied the code from core
…e boolean we already use
|
sirambd
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR still lacks the correct pager indicator, but for now I've put a quick placeholder code and I will code and style the indicator in the following PR.
This PR creates a generic OnboardingScaffold inside Core2 and uses it inside the app