Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Polish import screen #220

Merged
merged 13 commits into from
Dec 6, 2024
Merged

refactor: Polish import screen #220

merged 13 commits into from
Dec 6, 2024

Conversation

FabianDevel
Copy link
Contributor

No description provided.

@FabianDevel FabianDevel added the enhancement New feature or request label Nov 28, 2024
@FabianDevel FabianDevel requested a review from LunarX November 28, 2024 14:34
@FabianDevel FabianDevel marked this pull request as draft November 29, 2024 12:39
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First comments, the rest will come later

Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments, the rest will once again come later

@FabianDevel FabianDevel requested a review from LunarX December 3, 2024 07:15
@FabianDevel FabianDevel marked this pull request as ready for review December 3, 2024 07:15
@FabianDevel FabianDevel force-pushed the polish-import-screen branch 5 times, most recently from 152c20a to 271acb3 Compare December 4, 2024 13:00
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to make sure the bottom sheet scaffold that also uses the DoubleButtonCombo uses the correct padding

@FabianDevel FabianDevel force-pushed the polish-import-screen branch 3 times, most recently from 5d61e3b to 9e2256e Compare December 5, 2024 14:14
Copy link

sonarqubecloud bot commented Dec 5, 2024

@FabianDevel FabianDevel merged commit 3e2bce7 into main Dec 6, 2024
6 checks passed
@FabianDevel FabianDevel deleted the polish-import-screen branch December 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants