fix: HighlighterText's text when the argument is the last characters of the whole string #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The range passed as argument to getBoundingBoxesForRange should stop at the last index of the string to not crash with an out of bound exception.
the right coordinate of the each returned bounding box should be defined based on the current bounding box's last character's rect. This wasn't properly handled when the last character of the current bounding box was in any line but the last one of the whole string vs when it was at the end of the whole string
|
LunarX
changed the title
tevincent
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two issues when the argument of a HighlighterText are the last characters of the whole string. This PR also refactors the code to make it easier to understand because things were not named very clearly. The refactor and the fixes are visible in different commits.
Details of the bugs:
The range passed as argument to getBoundingBoxesForRange should stop at the last index of the string to not crash with an out of bound exception.
Also, the right coordinate of the each returned bounding box should be defined based on the current bounding box's last character's rect. This wasn't properly handled when the last character of the current bounding box was in any line but the last one of the whole string vs when it was at the end of the whole string