Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove dead code #168

Merged
merged 4 commits into from
Nov 13, 2024
Merged

refactor: Remove dead code #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
352582d
refactor: Remove comment that doesn't make any sense
KevinBoulongne Nov 12, 2024
1b8a691
refactor: Remove dead code
KevinBoulongne Nov 12, 2024
4a076fe
refactor: Delete unused `SentListScreen`
KevinBoulongne Nov 12, 2024
c13c3df
refactor: Remove double jumped lines
KevinBoulongne Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core2/src/main/res/values-fr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
~ You should have received a copy of the GNU General Public License
~ along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<resources xmlns:tools="http://schemas.android.com/tools">
<resources>
<string name="buttonCancel">Annuler</string>
<string name="buttonRetry">Réessayer</string>
</resources>
2 changes: 0 additions & 2 deletions app/src/main/java/com/infomaniak/swisstransfer/ui/components/Buttons.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import com.infomaniak.swisstransfer.ui.theme.Dimens
import com.infomaniak.swisstransfer.ui.theme.Margin
import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme


/**
* Specifying a progress has the priority over specifying showIndeterminateProgress
*/
Expand Down Expand Up @@ -70,7 +69,6 @@ fun LargeButton(
)
}


/**
* Specifying a progress has the priority over specifying showIndeterminateProgress
*/
Expand Down
1 change: 0 additions & 1 deletion app/src/main/java/com/infomaniak/swisstransfer/ui/components/CrossCircleButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ fun BoxScope.CrossCircleButton(onClick: (() -> Unit)?, size: Dp = 48.dp) {
}
}


@PreviewLightAndDark
@Composable
private fun CrossCircleButtonPreview() {
Expand Down
1 change: 0 additions & 1 deletion .../infomaniak/swisstransfer/ui/images/illus/uploadError/GhostMagnifyingGlassQuestionMark.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
*/
package com.infomaniak.swisstransfer.ui.images.illus.uploadError


import android.content.res.Configuration
import androidx.compose.foundation.Image
import androidx.compose.foundation.layout.Box
Expand Down
1 change: 0 additions & 1 deletion ...c/main/java/com/infomaniak/swisstransfer/ui/screen/main/received/ReceivedScreenWrapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ private fun DetailPane(navigator: ThreePaneScaffoldNavigator<String>) {
}
}

// Show the detail pane content if selected item is available
@Composable
private fun NoSelectionEmptyState() {
Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
Expand Down
53 changes: 0 additions & 53 deletions app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/sent/SentListScreen.kt
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/sent/SentScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,7 @@ private fun SentScreen(transfers: List<Any>?) {
}
},
) {
if (transfers.isEmpty()) {
SentEmptyScreen()
} else {
SentListScreen(transfers)
}
if (transfers.isEmpty()) SentEmptyScreen()
}
}

Expand Down
1 change: 0 additions & 1 deletion ...c/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/SettingsScreenWrapper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ private fun DetailPane(
}
}

// Show the detail pane content if selected item is available
@Composable
private fun NoSelectionEmptyState() {
Box(modifier = Modifier.fillMaxSize(), contentAlignment = Alignment.Center) {
Expand Down
1 change: 0 additions & 1 deletion ...nfomaniak/swisstransfer/ui/screen/newtransfer/importfiles/components/ImportedFilesCard.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ private data class TransferLazyRowKey(
}
}


@PreviewLightAndDark
@Composable
private fun ImportedFilesCardPreview(@PreviewParameter(FileUiListPreviewParameter::class) files: List<FileUi>) {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values-fr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
~ You should have received a copy of the GNU General Public License
~ along with this program. If not, see <http://www.gnu.org/licenses/>.
-->
<resources xmlns:tools="http://schemas.android.com/tools">
<resources>
<string name="advancedSettingsTitle">Paramètres avancés</string>
<string name="buttonAddFiles">Ajouter des fichiers</string>
<string name="buttonCancel">Annuler</string>
Expand Down
Loading