feat: Make Sent screen use the ScreenWrapper #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
3 times, most recently
from
791802d to
7acdafa
Compare
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
fceb82b to
1e6f160
Compare
KevinBoulongne
force-pushed
the
clean-code
branch
from
6267646 to
d12d82c
Compare
KevinBoulongne
changed the base branch from
clean-code
to
transfersList-with-expiredBottomSheet
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
621e968 to
1ef66b8
Compare
KevinBoulongne
force-pushed
the
transfersList-with-expiredBottomSheet
branch
from
25edbd4 to
76b1306
Compare
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
2 times, most recently
from
0260bbd to
e4d6dd3
Compare
KevinBoulongne
changed the base branch from
transfersList-with-expiredBottomSheet
to
extract-emailsFlowRow
KevinBoulongne
force-pushed
the
extract-emailsFlowRow
branch
from
568fbcd to
6414ed3
Compare
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
3 times, most recently
from
1881055 to
c924d10
Compare
KevinBoulongne
force-pushed
the
extract-emailsFlowRow
branch
from
6414ed3 to
b497846
Compare
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
c924d10 to
bba938a
Compare
KevinBoulongne
force-pushed
the
extract-emailsFlowRow
branch
2 times, most recently
from
3aecfd3 to
b5d6568
Compare
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
bba938a to
39c8213
Compare
|
This PR/issue depends on:
|
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
39c8213 to
0365c1f
Compare
FabianDevel
requested changes
Nov 13, 2024
There was a problem hiding this comment.
I wonder if it would not be easier to simply have a single screen for both received and sent that takes the particularities of each in callbacks passed from the wrapper, as this wrapper already check the direction.
But even if we decide it's a good idea, it should be done later
app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/components/transfer/TransferItemList.kt
Outdated
Show resolved
Hide resolved
...rc/main/java/com/infomaniak/swisstransfer/ui/screen/main/transfers/TransfersScreenWrapper.kt
Outdated
Show resolved
Hide resolved
tevincent
approved these changes
Nov 13, 2024
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
2 times, most recently
from
88d2074 to
bb46f9e
Compare
sirambd
approved these changes
Nov 13, 2024
FabianDevel
approved these changes
Nov 13, 2024
KevinBoulongne
force-pushed
the
sent-two-pane-scaffold
branch
from
bb46f9e to
0e4cf51
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #173