Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add FilesDetailScreen #117

Draft
wants to merge 35 commits into
base: main
Choose a base branch
from
Draft

feat: Add FilesDetailScreen #117

wants to merge 35 commits into from

Conversation

tevincent
Copy link
Contributor

@tevincent tevincent commented Oct 23, 2024 •
edited
Loading

file_nav.mp4

Depends on Infomaniak/multiplatform-SwissTransfer#81

Screen to display details of files provided by the parameter filesList.

Can be configured like this:

  • navigateToDetails: this callback is called when the user click on a file
  • withSpaceLeft: if we want to display the space left, useful when displaying files of a transfer
  • onFileRemoved: callback called when the user click on the cross to delete a file. If not provided, the cross on files will not be displayed
  • onCloseClicked: callback called when the cross on the TopAppBar is clicked
  • navigateBack: this callback is called when the user want to navigate back

@tevincent tevincent marked this pull request as draft October 23, 2024 10:50
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from 8c58665 to c57de0e Compare October 23, 2024 12:08
@tevincent tevincent changed the title Add FilesDetailScreen feat: Add FilesDetailScreen Oct 23, 2024
@tevincent tevincent marked this pull request as ready for review October 24, 2024 06:36
@tevincent tevincent marked this pull request as draft October 24, 2024 07:03
@tevincent tevincent marked this pull request as ready for review October 24, 2024 12:29
@tevincent tevincent force-pushed the details-files branch 2 times, most recently from 79c1b3e to 6295db8 Compare October 25, 2024 08:29
LunarX
LunarX requested changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@LunarX LunarX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this screen being used in another PR already? If it is, then it's fine like this but if it's not, we should use the screen already for the imported files during a new transfer, it could help see some details and issue we might not have thought about

app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferTopAppBar.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/MainNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
...java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/FilesDetailsViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
...in/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/importfiles/FilesDetailsScreen.kt Outdated Show resolved Hide resolved
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from 57b7150 to bb9b3b7 Compare October 30, 2024 13:52
tevincent
tevincent commented Oct 30, 2024
View reviewed changes
app/src/main/java/com/infomaniak/swisstransfer/ui/components/SwissTransferTopAppBar.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/MainNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/FilesSize.kt Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/NewTransferNavHost.kt Outdated Show resolved Hide resolved
app/src/main/java/com/infomaniak/swisstransfer/ui/utils/HumanReadableSizeUtils.kt Outdated Show resolved Hide resolved
@tevincent tevincent force-pushed the details-files branch 4 times, most recently from 6eb0c25 to d537d2b Compare October 31, 2024 10:37
@tevincent tevincent force-pushed the details-files branch 3 times, most recently from f295a40 to 749ed98 Compare November 4, 2024 13:24
@tevincent
Remove unused import
b9a7099
@tevincent
Remove unnecessary modifier
3119143
@tevincent
Add navigation for FilesDetailsScreen
b32e046
@tevincent
chore(FilesDetailsScreen): remove unused PreviewParameter
c6ae24a
@tevincent
chore: Code review
139eb74
@tevincent
chore: Code review
e8290a9
@tevincent
chore: Modify FileUI
50b1567
@tevincent
chore: Use TextDot
c8587c5
@tevincent
chore: Remove getSpaceUsed and use getHumaneReadableSize
1ada4fe
@tevincent
chore: Fix merge conflict
ad180cd
@tevincent
chore: Add missing import
8083886
@tevincent
chore: Code review
9285abd
@tevincent
chore: Fix merge
30706ce
@tevincent
fix: Use a shared viewmodel to get files in FilesDetailsScreen
229129b
@tevincent
fix: Add Folder type
0eddb5a
@tevincent
feature: Use the files navigator from the main screen and from a new …
46ab985 
…transfer
@tevincent
chore: Clean code
781a4a8
@tevincent
chore: Clean code
b46c26a
@tevincent
chore: Fix code after rebase
8b75726
@tevincent
chore: Remove redundant arguments name
8c748ae
@tevincent
chore: Use a variable for topAppBar in MainScaffold
7c1e2b7
@tevincent
fix: Use formatShortFileSize
ed66d92
@tevincent
chore: Remove unused parameter
def5f7a
@tevincent
chore: Use real transfers
4c3aa61
@tevincent
chore: remove parameter
75d7783
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LunarX LunarX LunarX requested changes

@KevinBoulongne KevinBoulongne KevinBoulongne approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@tevincent tevincent

Labels
dependent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tevincent @KevinBoulongne @LunarX