refactor: Rename CustomShapes variables #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinBoulongne
force-pushed
the
rename-custom-shapes
branch
3 times, most recently
from
3a50f65 to
647be77
Compare
LunarX
requested changes
Oct 17, 2024
There was a problem hiding this comment.
I agree that we need all five values to either start with an uppercase or a lowercase. I don't know which one is better though, I'd wait on @sirambd if he has an opinion on it.
Still, can't we do anything in order to name it Shapes instead of CustomShapes?
KevinBoulongne
force-pushed
the
rename-custom-shapes
branch
2 times, most recently
from
2d1977c to
d05526b
Compare
tevincent
approved these changes
Oct 21, 2024
KevinBoulongne
force-pushed
the
rename-custom-shapes
branch
from
d05526b to
25ded7b
Compare
sirambd
approved these changes
Oct 21, 2024
KevinBoulongne
force-pushed
the
rename-custom-shapes
branch
from
ef1453c to
7d85793
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.