Skip to content

Commit

Permalink
fix: Add missing contentDescription for onboarding next button
Browse files Browse the repository at this point in the history
  • Loading branch information
LunarX committed Dec 4, 2024
1 parent 16be839 commit cef1962
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 10 deletions.
1 change: 1 addition & 0 deletions Core2/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
-->
<resources>
<string name="buttonCancel">Abbrechen</string>
<string name="buttonNext">Weiter</string>
<string name="buttonRetry">Wiederholen</string>
</resources>
1 change: 1 addition & 0 deletions Core2/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
-->
<resources>
<string name="buttonCancel">Cancelar</string>
<string name="buttonNext">Siguiente</string>
<string name="buttonRetry">Reintentar</string>
</resources>
1 change: 1 addition & 0 deletions Core2/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
-->
<resources>
<string name="buttonCancel">Annuler</string>
<string name="buttonNext">Suivant</string>
<string name="buttonRetry">Réessayer</string>
</resources>
1 change: 1 addition & 0 deletions Core2/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
-->
<resources>
<string name="buttonCancel">Annulla</string>
<string name="buttonNext">Avanti</string>
<string name="buttonRetry">Riprova</string>
</resources>
1 change: 1 addition & 0 deletions Core2/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@
-->
<resources>
<string name="buttonCancel">Cancel</string>
<string name="buttonNext">Next</string>
<string name="buttonRetry">Retry</string>
</resources>
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import com.infomaniak.swisstransfer.ui.theme.Dimens
import com.infomaniak.swisstransfer.ui.theme.Margin
import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme
import com.infomaniak.swisstransfer.ui.utils.PreviewLightAndDark
import com.infomaniak.core2.R as RCore2

private const val BUTTON_ANIM_DURATION = 300
private const val BUTTON_ANIM_DELAY = BUTTON_ANIM_DURATION / 2
Expand Down Expand Up @@ -83,12 +84,12 @@ fun AnimatedOnboardingButton(isExpanded: () -> Boolean, onClick: () -> Unit) {
Icon(
modifier = Modifier.alpha(arrowVisibility),
imageVector = AppImages.AppIcons.ArrowRight,
contentDescription = null
contentDescription = stringResource(RCore2.string.buttonNext),
)
Text(
modifier = Modifier.alpha(textVisibility),
text = stringResource(id = R.string.buttonStart),
style = SwissTransferTheme.typography.bodyMedium
style = SwissTransferTheme.typography.bodyMedium,
)
}
}
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<string name="buttonDownload">Download</string>
<string name="buttonDownloadSelected">Auswahl herunterladen</string>
<string name="buttonFinished">Beenden</string>
<string name="buttonNext">Weiter zu</string>
<string name="buttonShare">Teilen</string>
<string name="buttonStart">Starten</string>
<string name="contentDescriptionButtonBack">Zurück</string>
Expand All @@ -32,7 +31,7 @@
<string name="contentDescriptionButtonRemove">Datei entfernen</string>
<string name="contentDescriptionButtonShowPassword">Passwort anzeigen</string>
<string name="contentDescriptionCreateNewTransferButton">Neuer Transfer</string>
<string name="downloadedTransferLabel">Heruntergeladene Übertragung : %d/%d</string>
<string name="downloadedTransferLabel">Heruntergeladene Übertragung: %d/%d</string>
<string name="errorTransferPasswordLength">Das Passwort muss zwischen 6 und 25 Zeichen lang sein</string>
<string name="expiresIn">Verfällt in %d Tagen</string>
<plurals name="filesCount">
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<string name="buttonDownload">Descargar</string>
<string name="buttonDownloadSelected">Descargar la selección</string>
<string name="buttonFinished">Acabado</string>
<string name="buttonNext">Siguiente</string>
<string name="buttonShare">Compartir</string>
<string name="buttonStart">Inicio</string>
<string name="contentDescriptionButtonBack">Volver</string>
Expand All @@ -32,7 +31,7 @@
<string name="contentDescriptionButtonRemove">Eliminar archivo</string>
<string name="contentDescriptionButtonShowPassword">Mostrar contraseña</string>
<string name="contentDescriptionCreateNewTransferButton">Nueva transferencia</string>
<string name="downloadedTransferLabel">Transferencia descargada : %d/%d</string>
<string name="downloadedTransferLabel">Transferencia descargada: %d/%d</string>
<string name="errorTransferPasswordLength">La contraseña debe tener entre 6 y 25 caracteres</string>
<string name="expiresIn">Caduca en %d días</string>
<plurals name="filesCount">
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<string name="buttonDownload">Télécharger</string>
<string name="buttonDownloadSelected">Télécharger la sélection</string>
<string name="buttonFinished">Terminer</string>
<string name="buttonNext">Suivant</string>
<string name="buttonShare">Partager</string>
<string name="buttonStart">Démarrer</string>
<string name="contentDescriptionButtonBack">Retour</string>
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
<string name="buttonDownload">Scaricare</string>
<string name="buttonDownloadSelected">Scarica la selezione</string>
<string name="buttonFinished">Finisci</string>
<string name="buttonNext">Avanti</string>
<string name="buttonShare">Condividi</string>
<string name="buttonStart">Inizio</string>
<string name="contentDescriptionButtonBack">Indietro</string>
Expand All @@ -32,7 +31,7 @@
<string name="contentDescriptionButtonRemove">Rimuovi il file</string>
<string name="contentDescriptionButtonShowPassword">Mostra password</string>
<string name="contentDescriptionCreateNewTransferButton">Nuovo trasferimento</string>
<string name="downloadedTransferLabel">Trasferimento scaricato : %d/%d</string>
<string name="downloadedTransferLabel">Trasferimento scaricato: %d/%d</string>
<string name="errorTransferPasswordLength">La password deve essere compresa tra 6 e 24 caratteri</string>
<string name="expiresIn">Scade tra %d giorni</string>
<plurals name="filesCount">
Expand Down
1 change: 0 additions & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
<string name="buttonDownload">Download</string>
<string name="buttonDownloadSelected">Download selection</string>
<string name="buttonFinished">Finish</string>
<string name="buttonNext">Next</string>
<string name="buttonShare">Share</string>
<string name="buttonStart">Start</string>
<string name="contentDescriptionButtonBack">Back</string>
Expand Down

0 comments on commit cef1962

Please sign in to comment.