review: Remove padding from IllustratedMessageBlock

Infomaniak · Oct 22, 2024 · b3308e9 · b3308e9
1 parent 31b8f27
commit b3308e9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/EmptyState.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/EmptyState.kt
@@ -20,6 +20,7 @@ package com.infomaniak.swisstransfer.ui.components
 import android.content.res.Configuration
 import androidx.annotation.StringRes
 import androidx.compose.foundation.layout.fillMaxSize
+import androidx.compose.foundation.layout.padding
 import androidx.compose.material3.Surface
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
@@ -28,6 +29,7 @@ import androidx.compose.ui.tooling.preview.Preview
 import com.infomaniak.swisstransfer.R
 import com.infomaniak.swisstransfer.ui.images.AppImages.AppIllus
 import com.infomaniak.swisstransfer.ui.images.illus.MascotSearching
+import com.infomaniak.swisstransfer.ui.theme.Margin
 import com.infomaniak.swisstransfer.ui.theme.SwissTransferTheme
 
 @Composable
@@ -37,7 +39,14 @@ fun EmptyState(
     @StringRes description: Int,
     modifier: Modifier = Modifier,
 ) {
-    IllustratedMessageBlock(icon, title, description, modifier.fillMaxSize())
+    IllustratedMessageBlock(
+        icon = icon,
+        title = title,
+        description = description,
+        modifier = modifier
+            .padding(horizontal = Margin.Medium)
+            .fillMaxSize(),
+    )
 }
 
 @Preview(name = "Light mode")

diff --git a/app/src/main/java/com/infomaniak/swisstransfer/ui/components/IllustratedMessageBlock.kt b/app/src/main/java/com/infomaniak/swisstransfer/ui/components/IllustratedMessageBlock.kt
@@ -45,7 +45,7 @@ fun IllustratedMessageBlock(
     modifier: Modifier = Modifier,
 ) {
     Column(
-        modifier = modifier.padding(horizontal = Margin.Medium),
+        modifier = modifier,
         verticalArrangement = Arrangement.Center,
         horizontalAlignment = Alignment.CenterHorizontally,
     ) {
@@ -74,7 +74,7 @@ fun IllustratedMessageBlock(
 @Preview(name = "Light mode")
 @Preview(name = "Dark mode", uiMode = Configuration.UI_MODE_NIGHT_YES or Configuration.UI_MODE_TYPE_NORMAL)
 @Composable
-private fun SwissTransferFabPreview() {
+private fun IllustratedMessageBlockPreview() {
     SwissTransferTheme {
         Surface {
             IllustratedMessageBlock(

diff --git a/...ava/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessEmailScreen.kt b/...ava/com/infomaniak/swisstransfer/ui/screen/newtransfer/upload/UploadSuccessEmailScreen.kt
@@ -61,6 +61,7 @@ private fun Content() {
             icon = AppIllus.UploadSuccessEmail.image(),
             title = R.string.uploadSuccessEmailTitle,
             description = R.string.uploadSuccessEmailDescription,
+            modifier = Modifier.padding(horizontal = Margin.Medium),
         )
 
         Spacer(Modifier.height(Margin.Small))