Skip to content

Commit

Permalink
Apply suggestions from code review to clean the code
Browse files Browse the repository at this point in the history
  • Loading branch information
LunarX committed Nov 13, 2024
1 parent 96ebda8 commit 0ea5fc6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,7 @@ private fun ColumnScope.ScreenContent(
private fun SuccessMessage(transferType: TransferType, transferUrl: String) {
Spacer(modifier = Modifier.height(Margin.Medium))

Image(
imageVector = AppIllus.Beers.image(),
contentDescription = null,
)
Image(imageVector = AppIllus.Beers.image(), contentDescription = null)

Spacer(Modifier.height(Margin.Huge))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,15 @@ fun ColumnScope.ShareAndCopyButtons(modifier: Modifier = Modifier, transferLink:
)
}
}

@Composable
private fun RowScope.ShareCopyButton(icon: ImageVector, @StringRes textRes: Int, onClick: () -> Unit) {
Button(
modifier = Modifier.weight(1f),
shape = CustomShapes.MEDIUM,
colors = ButtonType.SECONDARY.buttonColors(),
contentPadding = PaddingValues(vertical = Margin.Medium),
onClick = onClick
onClick = onClick,
) {
Column(
horizontalAlignment = Alignment.CenterHorizontally,
Expand All @@ -93,7 +94,6 @@ private fun RowScope.ShareCopyButton(icon: ImageVector, @StringRes textRes: Int,
}
}


@PreviewLightAndDark
@Composable
private fun Preview() {
Expand Down

0 comments on commit 0ea5fc6

Please sign in to comment.