ports/psoc6: Removed psoc6_gpio driver. #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: enriquezgarc <[email protected]>
IFX-Anusha
approved these changes
Sep 7, 2023
NikhitaR-IFX
approved these changes
Sep 7, 2023
| // function to check Pin.value | ||
| uint8_t gpio_get_value(uint32_t pin) { | ||
| if (gpio_is_out(pin)) { // if Pin.Mode is Pin.OUT, read output driver | ||
| return Cy_GPIO_ReadOut(CYHAL_GET_PORTADDR(pin), CYHAL_GET_PIN(pin)); |
There was a problem hiding this comment.
I understand this is moved here from drivers but I don't feel quite happy seeing HAL and PDL calls mixed here mainly because these are two types of abstraction and each requires different set of includes and different ways of accessing pins. I am not suggesting any changes here but this needs to be refactored and mostly will be addressed as part of https://jirard.intra.infineon.com/browse/DESMAKERS-3557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
CONTRIBUTING.md also tells you what to expect in the PR process.
Moving drivers/gpio directly to machine modules subclasses.