Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply overrides in FWTW #90

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Apply overrides in FWTW #90

merged 9 commits into from
Oct 1, 2024

Conversation

liuly12
Copy link
Collaborator

@liuly12 liuly12 commented Mar 16, 2024

initial_storage is currently not enabled

@liuly12 liuly12 linked an issue Mar 16, 2024 that may be closed by this pull request
@liuly12 liuly12 self-assigned this Mar 16, 2024
Copy link
Collaborator

@barneydobson barneydobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some basic suggestions for tests - otherwise happy

tests/test_wtw.py Show resolved Hide resolved
tests/test_wtw.py Outdated Show resolved Hide resolved
tests/test_wtw.py Outdated Show resolved Hide resolved
@liuly12 liuly12 requested a review from dalonsoa April 10, 2024 09:13
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now that tests and QA pass :)

@barneydobson barneydobson marked this pull request as ready for review October 1, 2024 12:06
@barneydobson barneydobson merged commit 1bad6b4 into main Oct 1, 2024
21 checks passed
@barneydobson barneydobson deleted the fwtw-overrides branch October 1, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FWTW overrides
3 participants