Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading times of the dash apps #400

Merged
merged 11 commits into from
Oct 22, 2024
Merged

Improve loading times of the dash apps #400

merged 11 commits into from
Oct 22, 2024

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Oct 21, 2024

This PR addresses the slow response of the dash apps by doing the following:

  • Reducing to a minimum the number of queries to the Measurement table, which is big and will only get bigger, storing the required information in a new variables field within the Station model.
  • Prevent the initial loading of the data in the reporting app, rather requiring from the user to click a button, as it is done in the Validation app. This lets the user decide on the station, variables and range of interest before plotting anything.

@dalonsoa dalonsoa changed the title WIP: Improve loading times of the dash apps Improve loading times of the dash apps Oct 21, 2024
@dalonsoa dalonsoa marked this pull request as ready for review October 21, 2024 08:55
@dalonsoa dalonsoa linked an issue Oct 21, 2024 that may be closed by this pull request
Copy link
Contributor

@Sahil590 Sahil590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better having the submit button and taking the dropdowns as state instead of as an input. Currently testing it with larger set of data but taking a while to load it in. LGTM from what I can see apart from the failing tests

@dalonsoa dalonsoa merged commit 236f75a into main Oct 22, 2024
5 checks passed
@dalonsoa dalonsoa deleted the faster_dash_apps branch October 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the "reports" and "validation" pages are very slow for large datasets
2 participants