Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Agent view page #59

Merged
merged 38 commits into from
Nov 21, 2023
Merged

Add Agent view page #59

merged 38 commits into from
Nov 21, 2023

Conversation

tsmbland
Copy link
Member

@tsmbland tsmbland commented Nov 3, 2023

Description

Agent view page

  • SLD images are done and working with random test data. Using the method from Phil (Agent view #35 (comment)). I'm creating a second SVG and overlaying it on top of the SLD image. Saves the SLD image from being redrawn every update. Just need to add a function to map input data to coordinates - I will set up a new issue
  • Map images are done using a similar approach to above. Not sure how they want the dots to be formatted but can easily be changed
  • Agent activity and EV charging breakdown figures are done using waffle plots. May need to change the layout a bit, and maybe think about pooling agents instead of a single square for every agent

Close #35

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (python -m pytest)
  • Pre-commit hooks run successfully (pre-commit run --all-files)

@tsmbland tsmbland changed the title Agent Add Agent view page Nov 3, 2023
@tsmbland tsmbland changed the base branch from main to market November 3, 2023 17:25
@AdrianDAlessandro
Copy link
Collaborator

If we remove the SVGs we should remember to squash and merge when we merge this

Base automatically changed from market to main November 15, 2023 13:26
@tsmbland tsmbland marked this pull request as ready for review November 16, 2023 12:05
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. A few changes suggested.

app/figures.py Outdated Show resolved Hide resolved
app/figures.py Outdated Show resolved Hide resolved
app/pages/agent.py Outdated Show resolved Hide resolved
app/pages/agent.py Outdated Show resolved Hide resolved
app/svg.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really good, I'm happy to merge it now

@AdrianDAlessandro AdrianDAlessandro merged commit 11b6c2a into main Nov 21, 2023
4 checks passed
@AdrianDAlessandro AdrianDAlessandro deleted the agent branch November 21, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent view
2 participants