Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish docker on release #151

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Publish docker on release #151

merged 2 commits into from
Oct 24, 2023

Conversation

tsmbland
Copy link
Member

Modifying workflow to publish docker image on release, instead of merges to main

Close #149

AdrianDAlessandro
AdrianDAlessandro requested changes Oct 24, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
AdrianDAlessandro
AdrianDAlessandro approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I believe this should work as intended. Can you update this branch so it's up-to-date with develop (rebase preferred) and then merge it? Both of those things should be doable via GitHub directly with the button in this PR.

@tsmbland tsmbland merged commit f2f7395 into develop Oct 24, 2023
6 checks passed
@tsmbland tsmbland deleted the publish branch October 24, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdrianDAlessandro AdrianDAlessandro AdrianDAlessandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use release workflow for publishing docker image
2 participants
@tsmbland @AdrianDAlessandro