Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install crispy forms #80

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Install crispy forms #80

merged 3 commits into from
Sep 18, 2024

Conversation

AdrianDAlessandro
Copy link
Contributor

Description

This goes part of the way to addressing #68 but does not completely close the issue since there is much more that can be done with it.

All this does is install crispy forms and use it to filter the existing form to get some bootstrap5 styling.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just 'crispy'fying the existing boot form.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm going to take the liberty of bootstraping the submit button as well and then merge this. I'm going to close #68 as this is totally fine for our purposes.

@cc-a cc-a enabled auto-merge September 18, 2024 16:28
@cc-a cc-a merged commit 39e53a7 into main Sep 18, 2024
4 checks passed
@cc-a cc-a deleted the crispy-forms branch September 18, 2024 16:29
@cc-a cc-a mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants