Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERS Kafka message topic #177

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ERS Kafka message topic #177

wants to merge 2 commits into from

Conversation

jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Oct 22, 2024

Description

Subscribe to erskafka-reporting and save messages.

Subscription uses a regex "^(control.*.process_manager|erskafka-reporting)". I wasn't sure if it was worth having two consumers for each topic (maybe threaded), versus having one consumer with an ever growing topic regex. Maybe a cleaner way of doing that.

A new topic field is added to the message model to discriminate (255 chars is the max length of topic name (actually it's 249 now) ).

Fixes #165

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (fb63f67) to head (1e838ce).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
main/management/commands/kafka_consumer.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   80.61%   81.15%   +0.53%     
==========================================
  Files          26       27       +1     
  Lines         325      329       +4     
==========================================
+ Hits          262      267       +5     
+ Misses         63       62       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Kafka message infrastructure
2 participants