Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make message feed hideable #142

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Make message feed hideable #142

merged 4 commits into from
Oct 10, 2024

Conversation

jamesturner246
Copy link
Contributor

@jamesturner246 jamesturner246 commented Oct 9, 2024

Description

Make the Kafka message feed hideable with _hyperscript (<- very nice syntax).

Users can hide the feed with the X icon, and click another button to open the feed. Each button is hidden when not relevant.

Screenshot from 2024-10-09 12-51-37

Screenshot from 2024-10-09 12-51-57

Fixes #120

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (61373b8) to head (4c37a48).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files          25       25           
  Lines         294      294           
=======================================
  Hits          233      233           
  Misses         61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well and is fluid. Very easy to understand, as well.

Copy link
Contributor

@cc-a cc-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd just suggest changing the id attributes to #hide-messages-button and #show-messages-button as I think these read a bit more clearly.

@jamesturner246
Copy link
Contributor Author

👍 Done.

@cc-a cc-a enabled auto-merge October 10, 2024 09:02
@cc-a cc-a merged commit e231526 into main Oct 10, 2024
4 checks passed
@cc-a cc-a deleted the hide_msg branch October 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Kafka message feed hideable
4 participants