-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise the controller app #132
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 44 44
=========================================
Hits 44 44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
Tiny tests question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok, however, as it is done, it seems that the current app (the process manager) is still the main app and the controller a dependent, somehow, based on the URL patterns and that the template is the one of the main app.
Possibly this is part of another PR, but I think that main
should be setup as an app in parallel to the controller, with all the common templates in the root directly and the URLs symmetric, one process_manager/
and the other controller/
.
Yes, that is to be tackled in #113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff.
Create process_manager app
Description
This PR adds a simple controller app to the repo. All it has is an index view and is linked to the current project in INSTALLED_APPS. I have tried to make as few changes as possible so that it will not have conflicts with #131 and when #113 is tackled.
The first commit is what is auto-generated by
python manage.py startapp controller
. So if you want to see my customisations, ignore that commit.Fixes #114
Type of change
Key checklist
python -m pytest
)python -m sphinx -b html docs docs/build
)pre-commit run --all-files
)Further checks