Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Kafka service to docker compose #103

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Add a Kafka service to docker compose #103

merged 2 commits into from
Sep 24, 2024

Conversation

cc-a
Copy link
Contributor

@cc-a cc-a commented Sep 24, 2024

Description

After spending a couple of hours with @jamesturner246 getting the Pocket Kafka distribution to work, I decided to take another look at getting Kafka into Docker Compose. Rather than the official Apache image I tried one produced by Bitnami and it seems to just work... 🤷 at least for our purposes.

You can now just run docker compose up to get a development stack including Kafka messages. This should enablethose who work on non-linux platforms.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass (eg. python -m pytest)
  • The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c582592) to head (4e84ba8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #103   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           43        43           
=========================================
  Hits            43        43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalonsoa
Copy link
Collaborator

Kafka-in-a-box:

image

Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to pretend that I understand any of the docker compose settings for the Kafka app, but it works and it will make the development way easier. Thanks for putting this together!!

@cc-a
Copy link
Contributor Author

cc-a commented Sep 24, 2024

I'm not going to pretend that I understand any of the docker compose settings for the Kafka app, but it works and it will make the development way easier. Thanks for putting this together!!

Good. Me either.

@cc-a cc-a enabled auto-merge September 24, 2024 20:47
@cc-a cc-a merged commit ae98bae into main Sep 24, 2024
4 of 5 checks passed
@cc-a cc-a deleted the kafka-in-a-box branch September 24, 2024 20:48
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Just to be on the same page: process-manager-no-kafka.json is no longer used, just there if the user wants to manually set up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants