Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit hook to keep dictionary file sorted #77

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add pre-commit hook to keep dictionary file sorted #77

merged 3 commits into from
Oct 31, 2024

Conversation

alexdewar
Copy link
Contributor

I've added a pre-commit hook to keep our dictionary file sorted, which should make it a bit tidier. It will also filter out duplicate entries.

I wanted it to be sorted in a case-insensitive manner, but this didn't work for me: pre-commit/pre-commit-hooks#1105

dc2917
dc2917 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dc2917 dc2917 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.wordlist.txt
MkDocs
MLOps
Modeling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢

.wordlist.txt Outdated
LinkedIn
jamesturner
jcohen
labeled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤢

HarmonicReflux
HarmonicReflux approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@HarmonicReflux HarmonicReflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to get the job done.

.wordlist.txt is somewhat hacky and get worse as we go, but working with spellchecker has been frustrating from my side: It checks what it should not and it is difficult to modify.

dalonsoa
dalonsoa approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handy 👍

Álvarez (my second surname) is the last on the list 😢

jamesturner246
jamesturner246 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jamesturner246 jamesturner246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. LGTM. 👍

@alexdewar
Copy link
Contributor Author

Álvarez (my second surname) is the last on the list 😢

Yeah. Clearly the sorting isn't Unicode aware 😞

@alexdewar alexdewar merged commit 435624a into main Oct 31, 2024
1 check was pending
@alexdewar alexdewar deleted the sort-dictionary branch October 31, 2024 16:11
@HarmonicReflux
Copy link
Contributor

This is handy 👍

Álvarez (my second surname) is the last on the list 😢

Well, thinking about it @dalonsoa, this will ensure that everyone checking the file reads your name (as hardly anyone ever scrolls up to the beginning of it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dc2917 dc2917 dc2917 approved these changes

@HarmonicReflux HarmonicReflux HarmonicReflux approved these changes

@jamesturner246 jamesturner246 jamesturner246 approved these changes

@dalonsoa dalonsoa dalonsoa approved these changes

@TinyMarsh TinyMarsh Awaiting requested review from TinyMarsh

@cc-a cc-a Awaiting requested review from cc-a

@AdrianDAlessandro AdrianDAlessandro Awaiting requested review from AdrianDAlessandro

@Sahil590 Sahil590 Awaiting requested review from Sahil590

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexdewar @HarmonicReflux @dalonsoa @jamesturner246 @dc2917