Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade infrastructure #276

Merged
merged 15 commits into from
Sep 9, 2024
Merged

Upgrade infrastructure #276

merged 15 commits into from
Sep 9, 2024

Conversation

dalonsoa
Copy link
Collaborator

@dalonsoa dalonsoa commented Aug 28, 2024

Among the many things, this PR

  • Uses pyproject.toml for project management
  • Upgrades docker image version
  • Upgrades versions of other services (eg. Azurite, etc.)
  • Uses our current setup for GitHub workflows
  • Updates code to use modern dependencies way of doing things (eg. bootstrap)
  • Replaces isort, flake8 and black with ruff
  • Update pre-commit to use our current list of hooks

Close https://github.com/ImperialCollegeLondon/rse_maintenance_tasks/issues/10

@dalonsoa dalonsoa marked this pull request as draft August 28, 2024 17:06
@dalonsoa dalonsoa marked this pull request as ready for review August 29, 2024 12:33
@dalonsoa
Copy link
Collaborator Author

The vast majority of what appear as changed is the linters and formatters.

Copy link
Collaborator

@AdrianDAlessandro AdrianDAlessandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't had the chance to actually test it. It all seems good to me. I've made a couple of observations

Dockerfile Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
management/apps.py Outdated Show resolved Hide resolved
@AdrianDAlessandro
Copy link
Collaborator

When I tried running this I got this:

Attaching to faraday-liionsden-azurite-1, faraday-liionsden-db-1, faraday-liionsden-web-1
faraday-liionsden-db-1       | 
faraday-liionsden-db-1       | PostgreSQL Database directory appears to contain a database; Skipping initialization
faraday-liionsden-db-1       | 
faraday-liionsden-azurite-1  | Azurite Blob service is starting at http://0.0.0.0:10000
faraday-liionsden-azurite-1  | Azurite Blob service is successfully listening at http://0.0.0.0:10000
faraday-liionsden-azurite-1  | Azurite Queue service is starting at http://0.0.0.0:10001
faraday-liionsden-azurite-1  | Azurite Queue service is successfully listening at http://0.0.0.0:10001
faraday-liionsden-azurite-1  | Azurite Table service is starting at http://0.0.0.0:10002
faraday-liionsden-azurite-1  | Azurite Table service is successfully listening at http://0.0.0.0:10002
faraday-liionsden-db-1       | 2024-09-06 16:10:48.223 UTC [1] FATAL:  database files are incompatible with server
faraday-liionsden-db-1       | 2024-09-06 16:10:48.223 UTC [1] DETAIL:  The data directory was initialized by PostgreSQL version 13, which is not compatible with this version 15.8 (Debian 15.8-1.pgdg120+1).
faraday-liionsden-db-1 exited with code 1
dependency failed to start: container for service "db" exited (1)

It appears like this means this will not work with any existing databases. If there are no databases, then this isn't a problem.

@dalonsoa
Copy link
Collaborator Author

dalonsoa commented Sep 6, 2024 via email

@dalonsoa dalonsoa merged commit 99858bc into develop Sep 9, 2024
4 checks passed
@dalonsoa dalonsoa deleted the upgrade branch September 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants