-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mandatory names #224
Mandatory names #224
Conversation
… manditory and unique
e121039
to
a73bf7c
Compare
Yeah it looks like we might need to adjust that view. I can't see a way of doing it without |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice addition to the tests too. Just a couple of small suggestions and a question about having unique=True
in the abstract base model.
Co-authored-by: Dan Davies <[email protected]>
This begins the tasks set out in #118 (comment) beginning with the making the
name
field mandatory and unique for most of the models.This almost works. It's failing with
'NoneType' object has no attribute 'institution'
because theuser_owner
attribute of the Experiment is not set until after the form validity is checked here https://github.com/ImperialCollegeLondon/Faraday-liionsden/blob/develop/common/views.py#L74Also, it is currently based from the
auto-mass
branch.Edit: I found a way to add the user to the form before checking its validity. I believe this works as intended now and should make all the other forms that use this base form more robust.
It is now based off the
develop
branch, and should be merged after #220