-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NC] Add constraint 'mirror' and 'look at' toggles #64
Merged
ManlyMarco
merged 19 commits into
IllusionMods:main
from
RikkiBalboa:nc_invert_constraints
Mar 12, 2024
Merged
[NC] Add constraint 'mirror' and 'look at' toggles #64
ManlyMarco
merged 19 commits into
IllusionMods:main
from
RikkiBalboa:nc_invert_constraints
Mar 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Managed to figure out mirroring the LookAt, so I added that too. PR is otherwise done |
ManlyMarco
approved these changes
Mar 12, 2024
ManlyMarco
changed the title
Nc invert constraints
[NC] Add constraint 'mirror' and 'look at' toggles
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the features described here (in a different repo).
Adds the ability to mirror the contraint and to make the child look at the position of the parent.
To make updating easier I also moved the actual contraining logic to the Contraint class itself, and just call those methods. Since the contraint gets updatated in two places with the same logic.
Also fixes the deault values of the scale offsets to be 1 (which was already set to 1 when pressing the reset button) to get normal behaviour inverting the scale by default (does not effect the normal scaling constraint)