Unsign Tx and Delete PendingTx after Completion #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- validNumNeeded modifier - changeNumNeeded function - nNeeded is same across all txs
…into Javi_nNeeded
…into Javi_nNeeded
- Added todo comment on peculiarity with `delete` operator
…into Javi_unsignTx
alecchendev
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8 and unsign will delete pending transactions once there are 0 signers which should close #9 & #21.
I had an issue though when deleting pending tx structs from the pending mapping. Turns out mappings cannot be easily deleted from structs. From Solidity Docs on delete operator:
Not really worth fixing for this project, but it's good to know for the future.
The only time this would be an issue is if someone were to complete a pending tx and then create the very same pending tx (with the same hash), then all the previous signers would get an error if they were to sign it again since the previous signers mapping was not cleared.