-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(query-builder): update topic with nested queries and templating #5952
Conversation
en/components/query-builder.md
Outdated
```html | ||
<igx-query-builder #queryBuilder [entities]="this.entities"> | ||
<ng-template #searchValueTemplate igxQueryBuilderSearchValue let-expression="expression"> | ||
<input type="text" required [(ngModel)]="expression.searchVal" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we use an IgxSelectComponent as we decided the sample to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this snippet will be updated once we have a templating sample ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a very minor suggestion. Looks good otherwise! 👍
Co-authored-by: Mike Cherkasov <[email protected]>
Closes #5953
Checklist:
preview
\beta
../relative/path.md
IgxSelectComponent
,<igx-combo>
code blocks
for the names of classes / tags / propertiescode blocks
pending-localization
label when the review of the PR is done