Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(query-builder): update topic with nested queries and templating #5952

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

igdmdimitrov
Copy link
Contributor

@igdmdimitrov igdmdimitrov commented Sep 27, 2024

Closes #5953

Checklist:

  • check topic's TOC/menu and paragraph headings
  • Include TOC topic labels in topic content has a valuable update, it's new or considered as preview\ beta
  • link to other topics using ../relative/path.md
  • at the References section at the end of the topic add links to topics, samples, etc
  • reference API documentation instead of adding a section with API

  • use valid component names - [Data] Grid, IgxSelectComponent, <igx-combo>
  • use spell checker tool (VS Code, Grammarly, Microsoft Editor)
  • add inline code blocks for the names of classes / tags / properties
  • add language descriptor for the code blocks
  • check broken links (use browser add-on)
  • check if sample is working and fully visible in the topic
  • check if sample is working and fully visible in the StackBlitz
  • check if code blocks match the code in StackBlitz demo


  • do not resolve requested changes (leave that to the reviewer)
  • add pending-localization label when the review of the PR is done
  • add a member from the localization team to translate it

en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
en/components/query-builder.md Outdated Show resolved Hide resolved
```html
<igx-query-builder #queryBuilder [entities]="this.entities">
<ng-template #searchValueTemplate igxQueryBuilderSearchValue let-expression="expression">
<input type="text" required [(ngModel)]="expression.searchVal" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we use an IgxSelectComponent as we decided the sample to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this snippet will be updated once we have a templating sample ready.

@igdmdimitrov igdmdimitrov requested a review from Otixa September 27, 2024 12:24
Otixa
Otixa previously approved these changes Sep 30, 2024
Copy link
Contributor

@Otixa Otixa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a very minor suggestion. Looks good otherwise! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants