Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progressbars - fix issues after the refactoring #15270

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Progressbars - fix issues after the refactoring #15270

wants to merge 8 commits into from

Conversation

desig9stein
Copy link
Contributor

@desig9stein desig9stein commented Jan 20, 2025 •
edited
Loading

Closes #15268

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein
fix(progressbars): fix animation orientation on init,
9c3f3ee 
fix counter animation when switching between indeterminate and normal stat,
fix strip position and orientation,
fix sample issues
@desig9stein desig9stein requested a review from simeonoff January 20, 2025 09:31
@desig9stein desig9stein marked this pull request as ready for review January 20, 2025 09:31
simeonoff and others added 4 commits January 20, 2025 14:20
@simeonoff
Merge branch 'master' into mpopov/progress/fix-progressbar-issues
e78ea02
@desig9stein
fix(progressbars): fix animation orientation on init,
8f7c989 
fix counter animation when switching between indeterminate and normal stat,
fix strip position and orientation,
fix sample issues
make sure that value is hidden the same way as in web component
@desig9stein
fix(progressbars): updating the sample and strips orientation
3dc0a1f 
also rename the samples in the navdrawer so they a next to each other for easy testing
@desig9stein
fix(progressbars): remove the test for value change in indeterminate …
ef182d0 
…state since this is how it is working in web component
@desig9stein desig9stein added ❌ status: awaiting-test PRs awaiting manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 20, 2025
@desig9stein desig9stein removed the ❌ status: awaiting-test PRs awaiting manual verification label Jan 21, 2025
desig9stein and others added 2 commits January 21, 2025 17:05
@desig9stein
fix(progressbars): Fix counter animation when exiting indeterminate s…
1a3a4ca 
…tate ore removing text input value dynamically.

- fix fluent indeterminate animations
- Remove important overrides for integer and fraction variables
- update sample
@desig9stein
Merge branch 'master' into mpopov/progress/fix-progressbar-issues
f53b7a0
@desig9stein desig9stein added the ❌ status: awaiting-test PRs awaiting manual verification label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff Awaiting requested review from simeonoff

At least 1 approving review is required to merge this pull request.

Assignees

@didimmova didimmova

Labels
circular-progress linear-progress version: 19.1.x ❌ status: awaiting-test PRs awaiting manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progressbars - issues
3 participants
@desig9stein @didimmova @simeonoff