Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(*): unused standalone imports cleanup #15212

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

damyanpetev
Copy link
Member

@damyanpetev damyanpetev commented Jan 8, 2025

Since v19 Angular reports unused standalone imports. Those are surfaced by the lang service if you land on the file, but the lib build itself doesn't log them. Those surfaced from the strict checks from the demos app instead, for example:

[WARNING] TS-998113: IgxButtonDirective is not used within the template of IgxActionStripComponent [plugin angular-compiler]

    projects/igniteui-angular/src/lib/action-strip/action-strip.component.ts:80:8:
      80 │         IgxButtonDirective,
         ╵  

https://github.com/IgniteUI/igniteui-angular/actions/runs/12672621639/job/35317053267#step:16:32

Now that those are all cleared up, also upgrading all of the Extended Diagnostics to errors to prevent future such leftovers.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@damyanpetev damyanpetev added the 🧱 ci: build CI build related issues and PRs label Jan 8, 2025
@damyanpetev damyanpetev marked this pull request as ready for review January 8, 2025 15:43
@damyanpetev damyanpetev changed the title fix(*): unused standalone imports cleanup refactor(*): unused standalone imports cleanup Jan 20, 2025
@damyanpetev damyanpetev merged commit 40c6dfe into master Jan 20, 2025
5 checks passed
@damyanpetev damyanpetev deleted the dpetev/unused-imports-cleanup branch January 20, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧱 ci: build CI build related issues and PRs version: 19.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants