Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to the Fleet Management Sample & Addressing Comments #34

Open
wants to merge 11 commits into
base: vnext
Choose a base branch
from
Open

Improvements to the Fleet Management Sample & Addressing Comments #34

wants to merge 11 commits into from

Conversation

IMinchev64
Copy link
Contributor

Closes #20

  • remove in-line styles
  • change Status column badge assignment logic
  • refactor template for the details table in the Details tab
  • refactor the template for the driver details table in the card overlay
  • add Enum for periods
  • add interfaces for vehicle and driver details
  • component stylesheet overhaul
  • change some public methods/functions to protected
  • other small fixes

@IMinchev64 IMinchev64 requested a review from mddragnev January 23, 2025 07:56
mddragnev
mddragnev requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mddragnev mddragnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the casting from the positionStrategy

projects/fleet-management-grid/src/app/models/period.enum.ts Outdated
@@ -0,0 +1,6 @@
export enum PeriodEnum {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the enum after Period

@IMinchev64 IMinchev64 requested a review from mddragnev January 24, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mddragnev mddragnev mddragnev approved these changes

Assignees

@dkamburov dkamburov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional adjustments to the Fleet Management sample app
4 participants
@IMinchev64 @mddragnev @dkamburov @skrustev