[PicoXR] Use compressed ETC2 textures for environments #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svillar
force-pushed
the
picoxr_etc2_envs
branch
from
299dc1a
to
786424d
Compare
PicoOS v5.4 added support for ETC2 compressed textures. We removed support for PicoOS < v5.7 when the version check was added. This means that we can now finally switch to using compressed textures also for Pico devices. There is no need to distribute the PNG versions in the Pico package. That would save us 14MB in the distributed APK. Apart from that the external environments code was also modified to download the KTX versions of the textures. The already downloaded environments will be used though because we have the same id for the different formats of the same environment. But for the builtin ones, and new downloads the KTX versions would be the selected choice. Fixes #522
svillar
force-pushed
the
picoxr_etc2_envs
branch
from
786424d
to
d6bd6b4
Compare
javifernandez
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PicoOS v5.4 added support for ETC2 compressed textures. We removed support for PicoOS < v5.7 when the version check was added. This means that we can now finally switch to using compressed textures also for Pico devices.
There is no need to distribute the PNG versions in the Pico package. That would save us 14MB in the distributed APK. Apart from that the external environments code was also modified to download the KTX versions of the textures.
The already downloaded environments will be used though because we have the same id for the different formats of the same environment. But for the builtin ones, and new downloads the KTX versions would be the selected choice.
Fixes #522