[AOSP] Migrate to GameActivity #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NativeActivity was the original choice for the Android activity for the AOSP port because it's a natural choice for an activity with native code. That was causing issues in MagicLeap2 because key strokes in external bluetooth keyboards were filtered out. By switching to GameActivity we can get rid of that limitation. The migration only required an small adjustment in the back button handling code because the onKeyUp() event for the back button was not triggering the onBackPressed() as it does in NativeActivity.
javifernandez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeActivity was the original choice for the Android activity for the AOSP port because it's a natural choice for an activity with native code. That was causing issues in MagicLeap2 because key strokes in external bluetooth keyboards were filtered out.
By switching to GameActivity we can get rid of that limitation. The migration only required an small adjustment in the back button handling code because the onKeyUp() event for the back button was not triggering the onBackPressed() as it does in NativeActivity.