[OpenXR] Use includes from Maven package #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently improved our build process by getting the OpenXR library from Maven. That allowed us to, among other things, use the already compiled khronos loader instead of the propietary ones. However we could do even better by also using the maven package even for those configurations that require a propietary loader. In this case we would use it to get the OpenXR include files. This will allow us to remove the OpenXR-SDK submodule from the third parties repo as it won't be no longer needed.
javifernandez
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently improved our build process by getting the OpenXR library from Maven. That allowed us to, among other things, use the already compiled khronos loader instead of the propietary ones.
However we could do even better by also using the maven package even for those configurations that require a propietary loader. In this case we would use it to get the OpenXR include files.
This will allow us to remove the OpenXR-SDK submodule from the third parties repo as it won't be no longer needed.