[Pico] Add an OS version check #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far we only have version checks for Meta. However as we're planning to add more for other platforms is better to modularize it instead of creating a long list of chained if-else blocks that are hard to maintain.
Pico OpenXR runtime had several issues over the time. We had to add workarounds here and there to support those OS versions. As time passes by those workarounds just make the code more complex to maintain without any real benefit (as it affects really old versions of the OS). After this change Pico OS versions < v5.7.1 are no longer supported and Wolvic will refuse to start. This allows us to remove a lot of code workarounding runtime bugs including the legacy hand mesh renderer using spheres.
javifernandez
requested changes
Sep 15, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
javifernandez
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pico OpenXR runtime had several issues over the time. We had to add workarounds here and there to support those OS versions. As time passes by those workarounds just make the code more complex to maintain without any real benefit (as it affects really old versions of the OS).
After this change Pico OS versions < v5.7.1 are no longer supported and Wolvic will refuse to start.
This allows us to remove a lot of code workarounding runtime bugs including the legacy hand mesh renderer using spheres.