wpewebkit: Add patches for build fixes related to ENABLE(VIDEO) and Fix build for cortexa8hf-neon #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Applied patch to fix build issues when ENABLE(VIDEO) is disabled (https://bugs.webkit.org/show_bug.cgi?id=281253). - Added a patch to fix WebKitSettings build for !ENABLE(VIDEO) (https://bugs.webkit.org/show_bug.cgi?id=281424). - Fixed a build issue when ENABLE_WEB_AUDIO=OFF by avoiding the use of WebAudioEnabled when the feature is not defined (https://bugs.webkit.org/show_bug.cgi?id=281159). Signed-off-by: Pablo Saavedra <[email protected]>
- Addressed a regression in FELightingNeonParallelApplier.cpp build for cortexa8hf-neon by adjusting pixel data pointer handling after upstream changes (https://bugs.webkit.org/show_bug.cgi?id=276938). Signed-off-by: Pablo Saavedra <[email protected]>
aperezdc
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Patch LGTM.
Maybe you would prefer to update to version 2.46.2, which includes the patches.
Yes, I just saw the announcement. Yes. makes more sense to update the release. |
|
Closed in favour of #514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applied patch to fix build issues when ENABLE(VIDEO) is disabled (https://bugs.webkit.org/show_bug.cgi?id=281253).
Added a patch to fix WebKitSettings build for !ENABLE(VIDEO (https://bugs.webkit.org/show_bug.cgi?id=281424).
Fixed a build issue when ENABLE_WEB_AUDIO=OFF by avoiding the use of WebAudioEnabled when the feature is not defined (https://bugs.webkit.org/show_bug.cgi?id=281159).
Addressed a regression in FELightingNeonParallelApplier.cpp build for cortexa8hf-neon by adjusting pixel data pointer handling after upstream changes (https://bugs.webkit.org/show_bug.cgi?id=276938).
This PR is motivated in origin by these comments in PR #509: